Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing git tags when there's some #17

Open
Roms1383 opened this issue Feb 14, 2023 · 6 comments
Open

missing git tags when there's some #17

Roms1383 opened this issue Feb 14, 2023 · 6 comments
Assignees

Comments

@Roms1383
Copy link

Hi there ! I just literally tried out your tool and got this error (NoTag) while I do actually have tags in my repo, e.g. : v0.2.2.
My first assumption is that the format of my tags does not match with gitmoji-changelog-rust's expectations, or am I missing something ?

@fabienjuif
Copy link
Owner

fabienjuif commented Feb 14, 2023

Hello 👋 ,

Maybe this commit introduced the bug: 62c0b88

  1. Can you try to use the v0.3.0?
  2. If you want to stick with the v0.4.0, can you try to set the -r option with the current tag? The previous?
  3. Remember this rust version is a playground and a fork of: https://github.com/frinyvonnick/gitmoji-changelog if you want to give it a try!

Thank you for your interest

@fabienjuif fabienjuif self-assigned this Feb 14, 2023
@Roms1383
Copy link
Author

Maybe this commit introduced the bug: 62c0b88

  1. Can you try to use the v0.3.0?
    cargo install [email protected]

I just gave a try and indeed changelog shows up in the terminal !

If you want to stick with the v0.4.0, can you try to set the -r option with the current tag? The previous?

What is the -r option ?

@fabienjuif
Copy link
Owner

fabienjuif commented Feb 15, 2023

gitmoji-changelog --help

    -r, --release <release>    Set a version to the release (latest tag to HEAD). 
                               If not set, the commits after the latest tag will not be printed to the changelog.

I'll try to look at the the commit that introduced the bug (or revert it).
If you want to give it a look and fix it, go ahead!

Meanwhile, is it ok to use the 0.3.0 for you?

@Roms1383
Copy link
Author

no worries, it's perfectly ok to use 0.3.0! :)
if I get some spare time I'll try to look into it but can't promise.

@Roms1383
Copy link
Author

by the way mere guess here, but looking at the commit you pointed out it could come from these changes since it only checks the first entry of versions which I assume might contain many versions.

@fabienjuif
Copy link
Owner

Yep but then the NoTag error becomes useless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants