Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make core starter objects accessible in the app starter #512

Open
symphony-elias opened this issue May 6, 2021 · 2 comments
Open

Make core starter objects accessible in the app starter #512

symphony-elias opened this issue May 6, 2021 · 2 comments
Labels
good first issue Good for newcomers [type] enhancement New feature or request

Comments

@symphony-elias
Copy link
Contributor

Feature Request

Description of Problem:

When creating an extension app project (maven or gradle) depending solely on symphony-bdk-app-spring-boot-starter, one cannot access beans declared in symphony-bdk-core-spring-boot-starter like @Slash.
Reason is: symphony-bdk-app-spring-boot-starter depends on symphony-bdk-core-spring-boot-starter as a runtime dependency

Potential Solutions:

Make symphony-bdk-app-spring-boot-starter depends on symphony-bdk-core-spring-boot-starter as a compile dependency

@symphony-elias symphony-elias added [type] enhancement New feature or request good first issue Good for newcomers labels May 6, 2021
@symphony-elias symphony-elias added this to the 2.2.0 milestone May 6, 2021
@ystxn
Copy link
Member

ystxn commented May 6, 2021

Are other third-party transitive dependencies being considered in this enhancement or just the bdk app spring starter to bdk core spring starter?

Some notable ones include:

  • bdk core spring starter to spring-boot-starter (so as to set a reference compatibility baseline)
  • bdk handlebars to handlebars (to access utils like safe string)

@symphony-youri
Copy link
Contributor

Usually relying on Maven transitive dependencies is not considered a good practice :)
But I agree it makes sense for starter like modules to ease developer experience

@symphony-youri symphony-youri removed this from the 2.2.0 milestone Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers [type] enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants