Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propagating onEvent errors of EventListener not handled #119

Open
kaushiknsanji opened this issue Mar 21, 2021 · 0 comments
Open

Propagating onEvent errors of EventListener not handled #119

kaushiknsanji opened this issue Mar 21, 2021 · 0 comments

Comments

@kaushiknsanji
Copy link

In the Step - "Display data from Firestore", the provided code does not handle the case of propagating the Listen errors to the protected method onError() of FirestoreAdapter. If propagated, then only the user will be able to see a Snackbar in case of any Listen errors occurring due to improper Query, in the onEvent() callback of EventListener. This onError() method is overidden by subclasses of FirestoreAdapter to provide their own implementation for handling the FirebaseFirestoreException error passed to it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kaushiknsanji