Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract FileInputComponent as it's own ckanext #123

Open
3 tasks
ChasNelson1990 opened this issue Jul 16, 2024 · 1 comment
Open
3 tasks

Extract FileInputComponent as it's own ckanext #123

ChasNelson1990 opened this issue Jul 16, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@ChasNelson1990
Copy link
Member

Contact Details

[email protected]

Problem

We currently have the same JS source code across four projects. As we are now adding this to this repo it's an opportune time to extract it for future use.

Solution

  • Pull out the JS, CSS and Jinja for the FileInputComponent into it's own ckanext.
  • Add that ckanext to fjelltopp-infrastructure group vars for zarr-ckan, who-afro-ckan and who-romania-ckan (possibly by creating a shared funicular.ini config too)
  • Remove any left overs, e.g. web assets, etc.

Considerd Alternatives

@tomeksabala and I did discuss the following:

  • Using CKAN's preferred JS JQuery module system - we don't want to be locked into such an old system
  • Extracting purely JS and CSS and requiring projects that use it to add two lines to templates (<script/> and <div id="*"/>)
@ChasNelson1990 ChasNelson1990 added the enhancement New feature or request label Jul 16, 2024
@ChasNelson1990 ChasNelson1990 self-assigned this Jul 16, 2024
@ChasNelson1990
Copy link
Member Author

We have also asked on https://gitter.im/ckan/chat what the long-term overheads of having lots of small ckanexts could be

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant