From c626b60375342cfa787e19084b95422a12ed64b1 Mon Sep 17 00:00:00 2001 From: joshua-stone Date: Wed, 24 May 2023 20:46:17 -0400 Subject: [PATCH] Avoid using absolute paths for gh helper for improving interoperability outside flatpak (#153) --- README.md | 4 ++-- md.obsidian.Obsidian.yml | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index fb0ca00..bab0ff3 100644 --- a/README.md +++ b/README.md @@ -61,10 +61,10 @@ A git repo can also be set up by running the following: $ flatpak run --command=gh md.obsidian.Obsidian auth setup-git ``` -The `gh` binary can resolve to `/app/bin/gh` in `~/.gitconfig` after running `gh auth setup-git` in flatpak, which may be problematic if `gh` is needed outside of flatpak. This can be worked around like so: +The `gh` binary can resolve to `/app/bin/gh` in `~/.gitconfig` after running `gh auth setup-git` in flatpak, [which may be problematic if `gh` is needed outside of flatpak](https://github.com/cli/cli/issues/7420). This can be worked around like so: ``` -$ sed -i 's@/app/bin/@/usr/bin/@g' ~/.gitconfig +$ sed -i 's@/app/bin/@@g' ~/.gitconfig ``` ## Middle-click auto-scrolling diff --git a/md.obsidian.Obsidian.yml b/md.obsidian.Obsidian.yml index 120012f..6482cfc 100644 --- a/md.obsidian.Obsidian.yml +++ b/md.obsidian.Obsidian.yml @@ -28,6 +28,7 @@ finish-args: - --share=ipc - --persist=~/.ssh - --env=SSH_ASKPASS=/app/libexec/openssh/ssh-askpass + - --env=GH_PATH=gh - --env=OBSIDIAN_USE_WAYLAND=0 - --env=OBSIDIAN_DISABLE_GPU=0 - --env=OBSIDIAN_DISABLE_GPU_SANDBOX=0