Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Inconsistent spacing between header and sidebar #11

Open
zmitchell opened this issue Mar 12, 2024 · 5 comments
Open

[BUG] Inconsistent spacing between header and sidebar #11

zmitchell opened this issue Mar 12, 2024 · 5 comments
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@zmitchell
Copy link
Contributor

This causes the sidebar to jump around as you click different links in the sidebar.

Screenshot 2024-03-12 at 2 25 28 PM
Screenshot 2024-03-12 at 2 25 37 PM

@zmitchell zmitchell added the bug Something isn't working label Mar 12, 2024
@ghudgins
Copy link
Contributor

I could not reproduce this issue

Copy link
Contributor Author

It would be helpful if you listed what you tried

@ghudgins
Copy link
Contributor

there isn't any jumping when you click links at the same heading level. I don't perceive this as a bug

Large GIF (1088x830)

@zmitchell
Copy link
Contributor Author

"It doesn't jump when you click on these particular links" is a narrow definition for "not a bug". I doubt the original intention of the site is to have the text jump around like this when you click different links in the sidebar.

@ghudgins
Copy link
Contributor

I think it's working as the framework author intended - you're trading sidebar jumping for jumping you to anchor links "down the page" and, if it were me, I would take this implementation over the alternative. If there's a way to do both, great. but this feels like an over optimization of an already good solution (mkdocs is pretty popular and we're basically using vanilla). I suspect the solution we have is good enough and don't think we should work this as a bug

@ghudgins ghudgins added the documentation Improvements or additions to documentation label Apr 2, 2024
@bryanhonof bryanhonof transferred this issue from another repository Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants