-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update floxdocs to be WCAG AA compliant #5
Comments
I think this should get reshaped into "run the axe plugin on floxdocs and make accessibility updates where we are weak" and not be planned as a bug |
I just ran |
looks like it's just triggering on the pink text and not the gray text though. and only in light mode. would be good to update this ticket with the findings from the plugin |
@garbas do you know if we can pick different theme colors in light mode vs. dark mode? the main contrast issue is pink on white and it's really close to passing the contrast muster. we would want to pick a darker cc @rossturk |
Everything is possible to change, I think I chose the initial color from the design documents. I would only need somebody to select colors and then ping me to implement a change, it should be a fast change once we know which colors we want. |
brand color to try in light mode only we should also try to address the other points from the plugin (there's a small handfull) |
The current light mode body text is #666666, which has a contrast of 5.74 against the white background #FFFFFF. This passes the WCAG AA threshold of 4.5, but it fails the WCAG AAA threshold of 7. If we just use the brand color #1B1B1B for body text (the same color we use for the header) the contrast jumps to 17.2. You can play around with contrast in this color checker: https://webaim.org/resources/contrastchecker/ |
Acceptance Criteria
#E5006E
#1B1B1B
from#666666
Original issue
The current typeface color is a mid-gray on a white background, which gives the text low contrast against the background. Low contrast is hard on people with poor eyesight. We should make the body text closer to black to make it easier to read.
The text was updated successfully, but these errors were encountered: