Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some save() methods have arguments and shouldn't #365

Open
Temikus opened this issue Jun 22, 2018 · 1 comment
Open

Some save() methods have arguments and shouldn't #365

Temikus opened this issue Jun 22, 2018 · 1 comment
Labels
Milestone

Comments

@Temikus
Copy link
Member

Temikus commented Jun 22, 2018

File is probably fine but user/server should not have them

λ grep -R 'def save([a-z ]' .
./lib/fog/google/models/sql/user.rb:        def save(password: nil)
./lib/fog/storage/google_xml/models/file.rb:        def save(options = {})
./lib/fog/compute/google/models/server.rb:        def save(username: nil, public_key: nil)
@github-actions
Copy link

This issue has been marked inactive and will be closed if no further activity occurs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants