-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[com.google.fonts/check/description/broken_links] A 403 is not a broken link #4764
Comments
403 is HTTP Error: Forbidden. Are you sure this is used for redirects? I have never heard of that and it does not sound right to me. Is this specific site generating an invalid HTTP code? Or, if this is actually a common practice, then how would we distinguish it from actual "error forbidden" pages? |
com.google.fonts/check/description/broken_links On the Google Fonts profile. (issue fonttools#4764)
com.google.fonts/check/description/broken_links On the Google Fonts profile. (issue #4764)
I misdiagnosed this. In the browser, https://scriptsource.org/scr/Ital gives a redirect, but from a |
I have these cases: 🔥 FAIL Does DESCRIPTION file contain broken links? And I guess we will ignore them. Could we make some exceptions or at least change it to a WARN instead a FAIL? |
The 403 is fine, will look at the 404. |
Observed behaviour
Expected behaviour
A 403 is fine because it is often used to redirect a "friendly" URL (like the one above) to another URL in the CMS (in this case
https://scriptsource.org/cms/scripts/page.php?item_id=script_detail&key=Ital
).Also it shouldn't say farticle.
The text was updated successfully, but these errors were encountered: