Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[com.google.fonts/check/description/broken_links] A 403 is not a broken link #4764

Open
simoncozens opened this issue Jun 11, 2024 · 4 comments

Comments

@simoncozens
Copy link
Collaborator

Observed behaviour

The following links are broken in the farticle file:
https://scriptsource.org/scr/Ital (status code: 403)

Expected behaviour

A 403 is fine because it is often used to redirect a "friendly" URL (like the one above) to another URL in the CMS (in this case https://scriptsource.org/cms/scripts/page.php?item_id=script_detail&key=Ital).

Also it shouldn't say farticle.

@felipesanches
Copy link
Collaborator

403 is HTTP Error: Forbidden. Are you sure this is used for redirects? I have never heard of that and it does not sound right to me.

Is this specific site generating an invalid HTTP code?

Or, if this is actually a common practice, then how would we distinguish it from actual "error forbidden" pages?

felipesanches added a commit to felipesanches/fontbakery that referenced this issue Jun 21, 2024
com.google.fonts/check/description/broken_links
On the Google Fonts profile.

(issue fonttools#4764)
felipesanches added a commit that referenced this issue Jun 21, 2024
com.google.fonts/check/description/broken_links
On the Google Fonts profile.

(issue #4764)
@simoncozens
Copy link
Collaborator Author

I misdiagnosed this.

In the browser, https://scriptsource.org/scr/Ital gives a redirect, but from a requests request, it gives a 403. We need to be better at faking being a browser...

@emmamarichal
Copy link
Contributor

@felipesanches @simoncozens

I have these cases:

🔥 FAIL Does DESCRIPTION file contain broken links?
The following links are broken in the article file:
https://scriptsource.org/scr/Mong (status code: 403)
https://en.wiktionary.org/wiki/Category:Uyghurjin_script (status code: 404)
[code: broken-links]

And I guess we will ignore them. Could we make some exceptions or at least change it to a WARN instead a FAIL?

@simoncozens
Copy link
Collaborator Author

The 403 is fine, will look at the 404.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants