Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vertical-metrics-not-centered] Only for new fonts #4877

Open
emmamarichal opened this issue Oct 31, 2024 · 0 comments
Open

[vertical-metrics-not-centered] Only for new fonts #4877

emmamarichal opened this issue Oct 31, 2024 · 0 comments
Labels
Check improvement proposal

Comments

@emmamarichal
Copy link
Contributor

[vertical-metrics-not-centered]

Observed behaviour

Having the WARN for a font update:

⚠️ WARN Check if uppercase glyphs are vertically centered.
⚠️ WARN
Uppercase glyphs are not vertically centered in the em box.

Expected behaviour

Should we implement this WARN only for new fonts, since we can't allow regressions and v-metrics changes for updates?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Check improvement proposal
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@emmamarichal