Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port several things from cpython here #39

Closed
wants to merge 24 commits into from
Closed

Port several things from cpython here #39

wants to merge 24 commits into from

Conversation

mikekap
Copy link
Collaborator

@mikekap mikekap commented Mar 8, 2021

Closes #25

  • Fix bugs for in hangul composition check boundaries (python/cpython@d134809)
  • Copy the normalization test so it runs for us too
  • Implement is_normalized

@anthrotype
Copy link
Member

Thanks for this!

About the Travis CI failure, it seems like the current multibuild no longer supports python3.5. Since it has reached EOL for a while, I would suggest to remove it from the CI build matrix.

@anthrotype
Copy link
Member

what's the status of this?

@anthrotype
Copy link
Member

closing as superseded by #58

@anthrotype anthrotype closed this Oct 28, 2022
@SnoopJ
Copy link
Collaborator

SnoopJ commented Oct 28, 2022

@anthrotype I think #25 can be closed as well since this issue is marked as closing that one and it isn't clear which exact commits were being referred to

@anthrotype
Copy link
Member

but did your PR impelement is_normalized? If not maybe we should keep #25 open

@SnoopJ
Copy link
Collaborator

SnoopJ commented Oct 29, 2022

but did your PR impelement is_normalized? If not maybe we should keep #25 open

Hmm I guess I read the issue too quickly earlier. #58 does port some changes to the C-side is_normalize machinery, but it does not add is_normalize() to the Python-facing API. I have a vague recollection of there being an issue with doing this with the 3.7 C API (and I know I left is_normalized_quickcheck() out of the changes for a similar reason), but I'd need to have a look again to be totally sure.

#25 is still a valid need for unicodedata2 to have parity with upstream, it should be re-opened. Sorry about that noise! 😬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add is_normalize (port upstream)
3 participants