Have a link from session to video room #161
Conversation
|
New button 'JOIN ROOM' allow user to redirect to room, NOTE: Ensure that the room name of session (sync from eventyay-talk) same with room name at eventyay-video you want user redirect to
|
Reviewer's Guide by SourceryThis pull request adds a new button to the session info section that links directly to the video room. The implementation involves importing mapState from vuex to access the rooms state, adding a new computed property for rooms, and creating a method to fetch the room ID by name. Additionally, a new CSS class is added for styling the button. File-Level Changes
Tips
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @lcduong - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
|
Good! We need to test this further also with larger schedules. |
|
Hi @lcduong this feature does not work smoothly yet. In the test room of @odkhang here the "Join" button disappears during the page loading: https://video-dev.eventyay.com/schedule/talks/RAFUSN |
Summary by Sourcery
This pull request introduces a new feature that adds a button in the session info view, allowing users to join the corresponding video room directly. It also enhances the session component by integrating Vuex state to access room information.