Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing </body></html> #304

Closed
Gisleburt opened this issue Jul 18, 2023 · 1 comment
Closed

Missing </body></html> #304

Gisleburt opened this issue Jul 18, 2023 · 1 comment
Labels
C-bug Category: bug tribble-reported This issue was reported through Tribble.

Comments

@Gisleburt
Copy link

This issue is reporting a bug in the code of Perseus. Details of the scope will be available in issue labels.
The author described their issue as follows:

Missing

The steps to reproduce this issue are as follows:

Follow the quick start guide and serve the application, you need to "View Source" rather than Inspect as most browsers will add the mossing closing tags.

I'm brand new to Perseus (and loving it btw) so I might have missed something obvious. Happy to look at fixing it, but wanted to confirm that it actually was an issue first.

A minimum reproducible example is available at <>.

  • Hydration-related: false
  • The author is willing to attempt a fix: false
Tribble internal data

dHJpYmJsZS1yZXBvcnRlZCxDLWJ1Zw==

@github-actions github-actions bot added C-bug Category: bug tribble-reported This issue was reported through Tribble. labels Jul 18, 2023
@arctic-hen7
Copy link
Member

Ah yes, you'll probably find a lot of missing closing tags by default, as Perseus applies a highly aggressive minifier that strips many of them. Semantically, this ends up being fine, as browsers can interpret the HTML the same, but you can disable the minify feature if you'd like, or if you're having any problems with this.

I might close this for now, as it's expected behaviour, although I'd be very willing to accept a PR that adds some notice for this in the docs somewhere if you'd like to write that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: bug tribble-reported This issue was reported through Tribble.
Projects
None yet
Development

No branches or pull requests

2 participants