Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perseus-cli/0.4.2 crate is missing the tests folder #305

Closed
srid opened this issue Jul 22, 2023 · 3 comments
Closed

perseus-cli/0.4.2 crate is missing the tests folder #305

srid opened this issue Jul 22, 2023 · 3 comments
Labels
A-cli Area: command line interface D-easy Difficulty: easy

Comments

@srid
Copy link

srid commented Jul 22, 2023

https://crates.io/crates/perseus-cli/0.4.2 does not have https://github.com/framesurge/perseus/tree/main/packages/perseus-cli/tests

Trying to build this in Nix,

error: builder for '/nix/store/3v37xknb9ij2hsvazh4g0bqjscp2j3gi-perseus-cli-0.4.2.drv' failed with exit code 101;
       last 10 log lines:
       >    Compiling assert_fs v1.0.12
       >    Compiling perseus-cli v0.4.2 (/private/tmp/nix-build-perseus-cli-0.4.2.drv-0/perseus-cli-0.4.2.tar.gz)
       >    Compiling webpki v0.22.0
       >    Compiling sct v0.7.0
       >    Compiling webpki-roots v0.22.6
       >    Compiling ureq v2.6.2
       > error: couldn't read tests/lib.rs: No such file or directory (os error 2)
       >
       > error: could not compile `perseus-cli` (test "integration") due to previous error
       > warning: build failed, waiting for other jobs to finish...
       For full logs, run 'nix log /nix/store/3v37xknb9ij2hsvazh4g0bqjscp2j3gi-perseus-cli-0.4.2.drv'.

The crate is missing the tests/ folder:

image
@github-actions
Copy link

This repo is set up to triage issues with Tribble, but this issue couldn't be processed. If you deliberately didn't use Tribble to report this issue, you can safely ignore this warning. If you did, something's gone wrong here.

@arctic-hen7
Copy link
Member

Hey there, so sorry for the late reply on this, I've been really busy lately, but I am back! The reason for this is because the Perseus CLI tests are very heavy. I strongly recommend against running them locally, they take about half an hour on CI because they involve end-to-end testing of the entire build process. We make sure that everything passes before releasing, and you could check against GitHub Actions' records for this maybe? I'm not very familiar with Nix though, but I'm happy to help resolve this if you give me some more info about why it's required to run those particular tests.

@arctic-hen7 arctic-hen7 added A-cli Area: command line interface D-easy Difficulty: easy labels Aug 28, 2023
@arctic-hen7
Copy link
Member

@srid I'm closing this due to inactivity for now, but please let me know if it's still an issue for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cli Area: command line interface D-easy Difficulty: easy
Projects
None yet
Development

No branches or pull requests

2 participants