Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating to modern CMake? #80

Open
HiImJulien opened this issue Aug 17, 2020 · 1 comment
Open

Updating to modern CMake? #80

HiImJulien opened this issue Aug 17, 2020 · 1 comment

Comments

@HiImJulien
Copy link

HiImJulien commented Aug 17, 2020

This issue became quite lengthy; thus the TL;DR:

  • If I completely rewrite your CMakeLists' to use modern and idiomatic CMake, would you consider merging it?
  • Is there any reason to you're stuck on CMake 3.4?

The lengthy, descriptive issue:

Hey there!
At my work, we're using libFranka to command our pandas. It turned out to be quite hard to set up the dependencies on Windows for libFranka to compile properly.

To mitigate those issues, I wrote a "new" CMakeLists, with the following changes:

  • Search for POCO; if POCO is not available, download, configure and build it like any other target.
    (Same spiel for Eigen and Google Test)
  • Reformatted and started using new CMake functions such as target_link_options and etc..

This allows us, to use libFranka, without actually installing it. E.g. in our projects, we use FetchContent (or to be more precise, CPMFindPackage, which is find_package + FetchContent but in useful) to download libFranka and resolve its dependencies with the procedure described above.
This doesn't require the user to have anything set up, besides a proper C++14 Compiler and CMake, and makes the build "bulletproof".

I'd like to open a pull request and incorporate those changes, as well as other changes that clean up the build scripts.

This would allow anyone to get libFranka, your work, running easily, without any hassles.

However, this would require at least CMake 3.13 and a bit more work from my side.
Would you accept such a contribution?

Regards,
Julian

P.S.: The fork I am working on currently, is not done yet, but works for builds using libFranka

@AndreasKuhner
Copy link
Contributor

Hi @HiImJulien ,
if this issue is still here... if you have a fork where we could have a look, we could give you some feedback 😀

Cheers,
Andreas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants