Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate redundant code for register_athlete_team #66

Open
obscurerichard opened this issue Jan 2, 2019 · 0 comments
Open

Eliminate redundant code for register_athlete_team #66

obscurerichard opened this issue Jan 2, 2019 · 0 comments
Labels
good first issue help wanted Help wanted - can you take this on? refactor

Comments

@obscurerichard
Copy link
Member

obscurerichard commented Jan 2, 2019

The code in the freezing/web/data.py function register_athlete_team is derived from the code in freezingsaddles/freezing-sync/freezing/sync/data/athlete.py and has to be maintained in parallel right now. Figure out a way to extract the functionality and share it between the two.

Maybe this could move into freezing-model's orm class for Athlete.
Maybe it could live in a shared library both of these projects share.

This may also be related to #188 - related code calls this.

@obscurerichard obscurerichard added good first issue refactor help wanted Help wanted - can you take this on? labels Jan 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue help wanted Help wanted - can you take this on? refactor
Projects
None yet
Development

No branches or pull requests

1 participant