-
-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Internationalisation -- Help with Spanish #212
Comments
@CRomano31415 Nice! 🎉
Push early so people can help 👍
Depends, are you working on profanities or equality? |
Profanities. If anyone else can push before me, go for it - currently at work and won't be able to push for a few hours. |
In case of profanities, maybe there’s some lists like this already out there! |
Which is the status? How can I help? @CRomano31415 |
I've found some lists in discussion boards, there are no official ones that I have been able to find. But you can start putting it together. |
Que paso? Se habla espanol! Puedo ayudar. What's up? I know how to speak Spanish. I can help. I know a few inappropriate Spanish words and can contribute. Is it in the |
@CRomano31415 - I think the international 2 character code for Spanish is |
@MrBenJ Sounds good, do you want to start it? I have a huge list of words that I'm cleaning up but wasn't sure how to code them since some are not profane in some countries, but then I realized if it's profane to some, it should be flagged as profane so I'm almost done cleaning up. If you upload a json, I can add to it. I was looking at fr-json and I wasn't sure what the numbers next to the words were, do you know? |
@CRomano31415 - Sure thing. I'd be happy to start it off. Where are you finding |
Well, that is a great question, because I could have sworn I saw |
Ahh! It looks like that PR hasn't been merged into |
Hey @CRomano31415 - I wrote a little script to JSONify your list and added a couple of words that weren't on there. I made a pull request to your own repo here: CRomano31415/SpanishProfanity#1 In the comments, I mentioned that I set everything to a value of My coworker @fportela-ns actually helped out a little bit with some insults that were missing as well. |
Awesome!! I have no idea where to put that JSON file here, maybe @wooorm can guide us? Titus, we have a JSON file with spanish profanity, which repo do we add it to? |
Hey @CRomano31415 - My coworker @fportela-ns wants to help out and he's a native Spanish speaker. We found a few words in there that don't quite belong |
Also, as a fun side note, how many times in one's life can you say, "I have a file with Spanish profanity! Where do I put it!?" I'm giggling over here. |
I feel pretty good that my contribution to society today has been a list of profane words. |
hey @CRomano31415 have the PR ready 😄 honestly there are a LOT of words that I've no idea what they mean haha. But here's my contribution CRomano31415/SpanishProfanity#2. I just removed a few words that I consider can't be profane in any way, and marked as |
Related-to GH-195. Related-to GH-212. Closes GH-217. Reviewed-by: Titus Wormer <[email protected]>
@fportela-ns You mean @CRomano31415 I think 😉 This looks like a really good start! Awesome work all! |
@fportela-ns @wooorm @CRomano31415 I think the next best course of action is to grab @CRomano31415 's file and make a proper pull request to this repo: https://github.com/words/cuss I've already submitted a PR to |
@MrBenJ Hey ! can you pass over the jsonify script you used on the list ? I will very much need it actually :'D |
Hey @AhmedRedaAmin Sure thing. I whipped up an NPM package for you as a CLI tool: Here's the git repo if you feel like contributing :) You can install it globally with:
And use it like this:
Hope you like it :) |
Thanks @MrBenJ , that is AWESOME ! |
Soo, we landed Spanish in The next step is to add something for Spanish to |
Hey @wooorm - I have some time. I should be able to help out on |
@MrBenJ Awesome! And that’s fine, take your time! :) |
Hey all, just added some ES Venezuelan dialect profanities into feat(Profanity_ES): Adding Venezuelan dialect profanities. There is indeed a problem with all the ES profanity lists i find on the net, since ES is so geo sensitive, the only real way into solving this is actually trying to not add any word that could be used usually by public speakers, teachers, tv.. and that are correctly defined in the dictionary, even though they might be used by some dialect as profanities. |
This issue stems from the Inernationalisation issue #202
Currently working on:
Current challenges:
The text was updated successfully, but these errors were encountered: