Skip to content
This repository has been archived by the owner on Apr 9, 2021. It is now read-only.

Remove redundant tab #179

Open
shobhitagarwal1612 opened this issue Mar 6, 2019 · 15 comments · May be fixed by #333
Open

Remove redundant tab #179

shobhitagarwal1612 opened this issue Mar 6, 2019 · 15 comments · May be fixed by #333

Comments

@shobhitagarwal1612
Copy link
Contributor

There are 4 tabs displayed on clicking on any form from the main screen

  • Statistics
  • Received
  • Sent
  • Reviewed

Both received and reviewed contains the same list of instances. The items of received tab are non-clickable making it useless since the same list is also available in reviewed. The items in the reviewed tab are clickable and the instances can be reviewed and marked as approved / rejected.
This must be improved. I propose that those two can be combined together into one

@lakshyagupta21 Please provide your input. Others are also welcome to join to discussion

@shobhitagarwal1612 shobhitagarwal1612 changed the title Remove redundant reviewed tab Remove redundant tab Mar 6, 2019
@iadeelzafar
Copy link
Contributor

Maybe we can combine the two by renaming the Reviewed Tab to Received and remove the old Received Tab. And then, in Received tab we can mark the instances as approved/rejected using an icon/label.

@iamvasuh
Copy link
Contributor

iamvasuh commented Mar 6, 2019

We can apply the features of the reviewed tab to the received tab or vice-versa.
Instead of removing the redundant tab we can use it to display some other productive information like time, date, transfer-info etc. or a chart,graph to display that data.

@shobhitagarwal1612
Copy link
Contributor Author

Proposed solution:

  • Statistics
  • Sent
  • Received

@lakshyagupta21 @iadeelzafar @iamvasuh Thoughts?

@iamvasuh
Copy link
Contributor

The above-proposed solution looks great and we should make sure that the "Received" tab has all features of the "Reviewed" tab.

@rohap97
Copy link
Contributor

rohap97 commented Mar 23, 2019

Is anyone working on this?

@shobhitagarwal1612
Copy link
Contributor Author

No, it is still unclaimed

@devanshi7799
Copy link
Contributor

@shobhitagarwal1612 i would like to work on this

@lakshyagupta21
Copy link
Contributor

@devanshi7799 Sure go ahead and you can start with any open issues which are unclaimed. But do check if any issues have any open PRs or not.

@KomoderHell
Copy link

Is someone working on this? if not I would like to work on it

@ajay-prabhakar
Copy link
Contributor

Hello @SujayKaushik008 welcome to ODK, and thanks for showing intrest on solving issue
@devanshi7799 asked to work on this 6 days ago but she did not claimed it
Wait for her reply if she did not working you can work on this

@devanshi7799
Copy link
Contributor

@SujayKaushik008 As i am currently working on some other issues, i have not yet started woking on this one.
You can claim and work on this :)

@KomoderHell
Copy link

ok so to be clear the task is to remove the reviewed tab and change the received tab so that it has functionalities of both reviewed and received tabs.
@opendatakit-bot claim

@getodk-bot
Copy link
Member

Welcome to Open Data Kit, @SujayKaushik008! We just sent you an invite to collaborate on this repository at https://github.com/opendatakit/skunkworks-crow/invitations. Please accept this invite in order to claim this issue and begin a fun and rewarding experience contributing to Open Data Kit!

Here are some tips to get you off to a good start:

  • Please read the README.md and CONTRIBUTING.md in this repo. Those two documents have much of what you need to get started.
  • Join the ODK developer Slack to get help, chat about this issue, and meet the other developers.
  • Sign up and introduce yourself on the ODK community forum to meet the broader ODK community.

See you on the other side (that is, the pull request side)!

@KomoderHell KomoderHell linked a pull request Jan 7, 2020 that will close this issue
2 tasks
@getodk-bot
Copy link
Member

getodk-bot commented Jan 22, 2020

Hello @SujayKaushik008, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 15 days.

You can reclaim this issue or claim any other issue by commenting @opendatakit-bot claim on that issue.

Thanks for your contributions, and hope to see you again soon!

@qhb1001
Copy link

qhb1001 commented Mar 17, 2020

Hi @SujayKaushik008, I just noticed the checkCode bugs in your PR#333 for this issue. May I work on that to make it work through the integration part?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants