Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve inbound filters #80731

Open
Niryo opened this issue Nov 14, 2024 · 5 comments
Open

improve inbound filters #80731

Niryo opened this issue Nov 14, 2024 · 5 comments

Comments

@Niryo
Copy link

Niryo commented Nov 14, 2024

Problem Statement

In mobile, we have many requests that are coming from outdated clients, and it makes it hard to understand which errors are not relevant anymore (we keep getting errors that were already fixed in newer clients).
Our current way of overcoming this issue is to use inbound filters to filter out versions from old clients. The issue with that approach is that inbound filters are matched as strings, and we can't add filters like this for example: > 2.100155.0, in order to filter out all releases that are less than version 2.100155.0.
So in order to achieve something like that, we have some complex inbound filters that we update on every new release, and it looks like this:
com.app@2.?.+
com.app@2.??.+
com.app@2.???.+
com.app@2.????.+
com.app@2.?????.+
com.app@[0-1].??????.?+*
[email protected]?????.?+*
[email protected]??.?+*
[email protected][0-4]?.?+*
[email protected][0-4].?+*

Not pleasant at all as you can see.

Solution Brainstorm

One suggested solution would be to support reacher filter syntax, like suggested above.
Another option is to add whiteList filters instead of blacklist, so we could just say "filter out everything which isn't coming from this release and that release.

Product Area

Ingestion and Filtering

@getsantry
Copy link
Contributor

getsantry bot commented Nov 14, 2024

Assigning to @getsentry/support for routing ⏲️

@getsantry
Copy link
Contributor

getsantry bot commented Nov 14, 2024

Routing to @getsentry/product-owners-ingestion-and-filtering for triage ⏲️

@getsantry getsantry bot moved this from Waiting for: Support to Waiting for: Product Owner in GitHub Issues with 👀 3 Nov 14, 2024
@getsantry
Copy link
Contributor

getsantry bot commented Nov 14, 2024

Routing to @getsentry/product-owners-issues for triage ⏲️

@jangjodi
Copy link
Member

Thank you for the suggestion! I have added this to our backlog, though I am unsure when this can be prioritized.

@Dav1dde
Copy link
Member

Dav1dde commented Nov 14, 2024

Would an inverted glob pattern already solve this for you?
E.g. a syntax like [email protected] filtering everything except the version [email protected].

I know this is still far from a good user experience and not a solution (especially that this does not match well with multiple rules), but it may make configuring the filter a bit easier for your usecase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

4 participants