Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wgpu-core contains deadlocks #5572

Open
4 of 9 tasks
jimblandy opened this issue Apr 20, 2024 · 0 comments
Open
4 of 9 tasks

wgpu-core contains deadlocks #5572

jimblandy opened this issue Apr 20, 2024 · 0 comments
Assignees
@jimblandy
Labels
type: bug Something isn't working

Comments

@jimblandy
Copy link
Member

jimblandy commented Apr 20, 2024 •
edited
Loading

In the process of developing #5539, we identified at least one deadlock in wgpu-core, and I suspect there are others. We should fix these deadlocks, updating lock::rank as we go, and enable the lock::ranked run-time validation by default in debug builds (#5937).

The presence of deadlocks means that no cycle-free ranking of locks exists that won't cause panics in our current tests and examples. This means that the ranking defined in lock::rank must either remain incomplete, or we should change the implementation to permit ranking cycles for the time being. The latter option is unappealing, so we plan to land #5539 with an incomplete ranking, meaning that enabling the validate-locks feature will cause panics for now.

Issues for specific deadlocks:
@jimblandy jimblandy mentioned this issue Apr 20, 2024
Merged
jimblandy added a commit to jimblandy/wgpu that referenced this issue Apr 20, 2024
@jimblandy
[core] Enforce a deadlock-free locking order for Mutexes.
0097585 
If `debug_assertions` or the `"validate-locks"` feature are enabled,
change `wgpu-core` to use a wrapper around `parking_lot::Mutex` that
checks for potential deadlocks.

At the moment, `wgpu-core` does contain deadlocks, so the ranking in
the `lock::rank` module is incomplete, in the interests of keeping it
acyclic. gfx-rs#5572 tracks the work needed to complete the ranking.
jimblandy added a commit to jimblandy/wgpu that referenced this issue Apr 20, 2024
@jimblandy
[core] Enforce a deadlock-free locking order for Mutexes.
d723d15 
If `debug_assertions` or the `"validate-locks"` feature are enabled,
change `wgpu-core` to use a wrapper around `parking_lot::Mutex` that
checks for potential deadlocks.

At the moment, `wgpu-core` does contain deadlocks, so the ranking in
the `lock::rank` module is incomplete, in the interests of keeping it
acyclic. gfx-rs#5572 tracks the work needed to complete the ranking.
jimblandy added a commit to jimblandy/wgpu that referenced this issue Apr 21, 2024
@jimblandy
[core] Enforce a deadlock-free locking order for Mutexes.
88840af 
If `debug_assertions` or the `"validate-locks"` feature are enabled,
change `wgpu-core` to use a wrapper around `parking_lot::Mutex` that
checks for potential deadlocks.

At the moment, `wgpu-core` does contain deadlocks, so the ranking in
the `lock::rank` module is incomplete, in the interests of keeping it
acyclic. gfx-rs#5572 tracks the work needed to complete the ranking.
jimblandy added a commit to jimblandy/wgpu that referenced this issue Apr 22, 2024
@jimblandy
[core] Enforce a deadlock-free locking order for Mutexes.
510f139 
If `debug_assertions` or the `"validate-locks"` feature are enabled,
change `wgpu-core` to use a wrapper around `parking_lot::Mutex` that
checks for potential deadlocks.

At the moment, `wgpu-core` does contain deadlocks, so the ranking in
the `lock::rank` module is incomplete, in the interests of keeping it
acyclic. gfx-rs#5572 tracks the work needed to complete the ranking.
jimblandy added a commit to jimblandy/wgpu that referenced this issue Apr 22, 2024
@jimblandy
[core] Enforce a deadlock-free locking order for Mutexes.
57f184a 
If `debug_assertions` or the `"validate-locks"` feature are enabled,
change `wgpu-core` to use a wrapper around `parking_lot::Mutex` that
checks for potential deadlocks.

At the moment, `wgpu-core` does contain deadlocks, so the ranking in
the `lock::rank` module is incomplete, in the interests of keeping it
acyclic. gfx-rs#5572 tracks the work needed to complete the ranking.
jimblandy added a commit to jimblandy/wgpu that referenced this issue Apr 22, 2024
@jimblandy
[core] Enforce a deadlock-free locking order for Mutexes.
2aa7798 
If `debug_assertions` or the `"validate-locks"` feature are enabled,
change `wgpu-core` to use a wrapper around `parking_lot::Mutex` that
checks for potential deadlocks.

At the moment, `wgpu-core` does contain deadlocks, so the ranking in
the `lock::rank` module is incomplete, in the interests of keeping it
acyclic. gfx-rs#5572 tracks the work needed to complete the ranking.
jimblandy added a commit to jimblandy/wgpu that referenced this issue Apr 22, 2024
@jimblandy
[core] Enforce a deadlock-free locking order for Mutexes.
dae6efd 
If `debug_assertions` or the `"validate-locks"` feature are enabled,
change `wgpu-core` to use a wrapper around `parking_lot::Mutex` that
checks for potential deadlocks.

At the moment, `wgpu-core` does contain deadlocks, so the ranking in
the `lock::rank` module is incomplete, in the interests of keeping it
acyclic. gfx-rs#5572 tracks the work needed to complete the ranking.
jimblandy added a commit to jimblandy/wgpu that referenced this issue Apr 22, 2024
@jimblandy
[core] Enforce a deadlock-free locking order for Mutexes.
d8a6f55 
If `debug_assertions` or the `"validate-locks"` feature are enabled,
change `wgpu-core` to use a wrapper around `parking_lot::Mutex` that
checks for potential deadlocks.

At the moment, `wgpu-core` does contain deadlocks, so the ranking in
the `lock::rank` module is incomplete, in the interests of keeping it
acyclic. gfx-rs#5572 tracks the work needed to complete the ranking.
jimblandy added a commit that referenced this issue Apr 23, 2024
@jimblandy
[core] Enforce a deadlock-free locking order for Mutexes.
b3c5a6f 
If `debug_assertions` or the `"validate-locks"` feature are enabled,
change `wgpu-core` to use a wrapper around `parking_lot::Mutex` that
checks for potential deadlocks.

At the moment, `wgpu-core` does contain deadlocks, so the ranking in
the `lock::rank` module is incomplete, in the interests of keeping it
acyclic. #5572 tracks the work needed to complete the ranking.
@SludgePhD SludgePhD mentioned this issue May 4, 2024
Open
@jimblandy jimblandy self-assigned this May 20, 2024
@teoxoy teoxoy added the type: bug Something isn't working label Jul 3, 2024
This was referenced Jul 3, 2024
Open
Closed
@jimblandy jimblandy mentioned this issue Jul 10, 2024
Open
kelpsyberry added a commit to kelpsyberry/dust that referenced this issue Aug 6, 2024
@kelpsyberry
Update dependencies, clean up, fix GDB stub
6a3b248 
The hardware 3D renderer has been disabled due to
gfx-rs/wgpu#5572
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jimblandy jimblandy

Labels
type: bug Something isn't working
Projects
WebGPU for Firefox
Status: No status
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jimblandy @teoxoy