Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show path provenance in result comparison #3739

Open
aschackmull opened this issue Oct 3, 2024 · 1 comment
Open

Show path provenance in result comparison #3739

aschackmull opened this issue Oct 3, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request VSCode

Comments

@aschackmull
Copy link

Would it be possible to get the provenance information from flow paths shown in the compare view as well? Currently provenance shows up nicely in the paths in the alerts view, but when paths are shown in a comparison between two path-problem result sets, then there's no provenance shown.

@aschackmull aschackmull added the enhancement New feature or request label Oct 3, 2024
@github-actions github-actions bot added the VSCode label Oct 3, 2024
@jf205 jf205 removed their assignment Oct 16, 2024
@dbartol
Copy link
Contributor

dbartol commented Nov 20, 2024

Potential related issue, from @owenmc on Slack:

More feedback on the same feature (I'm comparing lots of results right now): sometimes it seems to think that two alerts are different when I think they're the same. Everything that is shown in the comparison is identical. I know that I've changed the model for the sink from one defined in ql to one defined in models-as-data. Is that what is causing them to be considered different? I would suggest that we should be robust to this.

While we're working on displaying the comparison results, we should also determine whether the provenance info was affecting the comparison even though it was not being displayed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request VSCode
Projects
None yet
Development

No branches or pull requests

3 participants