Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Block-level visibility for account edit forms #143

Open
thomasplevy opened this issue Oct 20, 2021 · 0 comments
Open

Allow Block-level visibility for account edit forms #143

thomasplevy opened this issue Oct 20, 2021 · 0 comments
Labels
hacktoberfest PRs for this issue count towards Hacktoberfest contributions! Type: Enhancement Improvements existing features or code Type: Feature Request This issue is an idea or request for a new feature

Comments

@thomasplevy
Copy link
Contributor

Related: #142

Currently, block level visibility is globally disabled for blocks in an account edit form.

This was added intentionally. Visibility is disabled for registration forms because they're only ever displayed to logged out users and as the inverse account edit forms are only shown to logged in users... However, given the scenario that a user creates a field (on checkout) that's only visible to users of Membership A and they want to display that field on the account edit form to users only enrolled in that membership, they cannot do this and the field is now shown to users regardless of their enrollment in membership A (on the account edit form).

However... there are fields on the account edit form that we should disable visibility for entirely:

Email, password, and display name should always be visible on the account edit form otherwise users cannot change essential account fields. Other fields can be conditionally visibile.

All fields that have visibility options enabled should have the "logged out" option removed since logged out users can't view the form it doesn't make sense to provide the option.

@thomasplevy thomasplevy added Type: Feature Request This issue is an idea or request for a new feature Type: Enhancement Improvements existing features or code hacktoberfest PRs for this issue count towards Hacktoberfest contributions! labels Oct 20, 2021
@thomasplevy thomasplevy moved this to Awaiting Triage in Development Mar 24, 2022
@thomasplevy thomasplevy moved this from Awaiting Triage to Backlog in Development Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest PRs for this issue count towards Hacktoberfest contributions! Type: Enhancement Improvements existing features or code Type: Feature Request This issue is an idea or request for a new feature
Projects
Status: Backlog
Development

No branches or pull requests

1 participant