Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storybook: Converting to 'exemplar' and adding Knobs story #40

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

msikora78
Copy link

This is to fix issues #39 and #38. Please let me know if you want me ti change anything...

Copy link
Contributor

@msluther msluther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one small suggestion on using the storybook preset mechanism to help clean some things up. otherwise 👍

@@ -29,7 +29,7 @@
"pretest": "npm run eslint",
"test": "npm run unit",
"prepublish": "npm run test && npm run build",
"storybook": "start-storybook"
"storybook": "start-storybook -c ./node_modules/@exemplar/storybook-react"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can get around having to do this by creating the file ./.storybook/presets.js and putting this in it:

module.exports = [
  '@exemplar/storybook-react'
];

Then this can still just be start-storybook

Base automatically changed from master to main February 3, 2021 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

integrate @exemplar/storybook-react package to enhance storybook. Add Storybook Knobs
3 participants