Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scan Using Revision or Current Branch #215

Open
dclayton-godaddy opened this issue Sep 2, 2021 · 0 comments
Open

Scan Using Revision or Current Branch #215

dclayton-godaddy opened this issue Sep 2, 2021 · 0 comments
Labels
design decision needed Maintainers must agree on a direction before this is worked on enhancement New feature or request

Comments

@dclayton-godaddy
Copy link
Contributor

Feature Request

Is your feature request related to a problem? Please describe.

When running tartufo via a GitHub PR Workflow, no commits are scanned due to how actions/checkout checks out the code as detached.

Describe the solution you'd like

If we add --current-branch to the scan-local-repo, we can scan whatever branch is checked out in the workflow.

OR

add --revision SHA1..SHA2 to enable any revision syntax offered by the underlying python git client.

Describe alternatives you've considered

  1. Don't use actions/checkout and git clone ...

Teachability, Documentation, Adoption, Migration Strategy
@dclayton-godaddy dclayton-godaddy added the enhancement New feature or request label Sep 2, 2021
@tarkatronic tarkatronic added the design decision needed Maintainers must agree on a direction before this is worked on label Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
design decision needed Maintainers must agree on a direction before this is worked on enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tarkatronic @dclayton-godaddy