From 2a5d8850b4e08a363072e692856362ba420937ef Mon Sep 17 00:00:00 2001 From: dpb Date: Thu, 29 Nov 2018 08:30:33 -0800 Subject: [PATCH] Ignore ECJ test in JDK 10 and 11 since ECJ doesn't work for us in those versions of the JDK. RELNOTES=n/a ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=223350143 --- .../src/test/java/com/google/auto/common/OverridesTest.java | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/common/src/test/java/com/google/auto/common/OverridesTest.java b/common/src/test/java/com/google/auto/common/OverridesTest.java index 17d273dbe7..d785b8cfb4 100644 --- a/common/src/test/java/com/google/auto/common/OverridesTest.java +++ b/common/src/test/java/com/google/auto/common/OverridesTest.java @@ -75,12 +75,14 @@ */ @RunWith(Parameterized.class) public class OverridesTest { + private static final ImmutableSet TOO_NEW_FOR_ECJ = ImmutableSet.of("9", "10", "11"); + @Parameterized.Parameters(name = "{0}") public static List data() { List compilerTypes = new ArrayList(); compilerTypes.add(new Object[] {CompilerType.JAVAC}); - if (!"9".equals(JAVA_SPECIFICATION_VERSION.value())) { - // TODO(emcmanus): make this test pass with ECJ on Java 9. + if (!TOO_NEW_FOR_ECJ.contains(JAVA_SPECIFICATION_VERSION.value())) { + // TODO(emcmanus): make this test pass with ECJ on Java > 8. // Currently it complains because it can't find java.lang.Object. Probably we need a newer // version of ECJ. compilerTypes.add(new Object[] {CompilerType.ECJ});