You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Given I set add-job-summary-as-pr-comment: 'on-failure',
And 'foo' job has failed leaving a PR comment with the failure
When a later run of 'foo' succeeds
Then should the failure comment be removed? From what I gathered, that's not implemented, so I'm opening a discussion about it. Repro of current behavior: gabrielfeo/develocity-api-kotlin#233
In my opinion, it'd be best to either remove the comment or update it with an OK sign and the latest (successful) build scan. When the job succeeds, the failure comment becomes outdated info.
The text was updated successfully, but these errors were encountered:
bigdaz
changed the title
Should successful runs remove past on-failure comments?
Remove or update existing PR comments when adding a new one
Apr 17, 2024
You're right we don't do anything to remove or modify previous job summary comments when submitting a new one.
Likely the ideal default behaviour would be to replace any outdated PR comments with a simple link to the GitHub Actions build (removing the large summary). Although removing it would also be reasonable behaviour I guess.
Then should the failure comment be removed? From what I gathered, that's not implemented, so I'm opening a discussion about it. Repro of current behavior: gabrielfeo/develocity-api-kotlin#233
In my opinion, it'd be best to either remove the comment or update it with an OK sign and the latest (successful) build scan. When the job succeeds, the failure comment becomes outdated info.
The text was updated successfully, but these errors were encountered: