Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring in --enable-werror and --enable-paranoid-warnings from libMesh #548

Open
pbauman opened this issue Jul 25, 2018 · 1 comment
Open

Comments

@pbauman
Copy link
Member

pbauman commented Jul 25, 2018

libMesh/libmesh#1797, libMesh/libmesh#1800, libMesh/libmesh#1812

We don't want to just take those by default when grabbing libMesh flags, I think, better to just configure separately on the GRINS side.

@roystgnr
Copy link
Member

Taking the libMesh ANY_WERROR_FLAG value ought to be safe, if you want us to add something on the libMesh side to export it.

Taking libMesh ANY_PARANOID_FLAGS would be safe by itself, but not in combination with -Werror, because I expect the sequence of "Roy notices a new compiler warning option, fixes all the libMesh warnings it triggers, then adds it to the list of libMesh paranoid warnings" will happen over and over again, and if GRINS just scarfs the libMesh list then any --enable-werror --enable-paranoid-warnings builds will suddenly fail after a corresponding libMesh upgrade.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants