Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label deployment and pod with app.kubernetes.io/version #192

Open
mloskot opened this issue Sep 13, 2024 · 0 comments
Open

Label deployment and pod with app.kubernetes.io/version #192

mloskot opened this issue Sep 13, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@mloskot
Copy link

mloskot commented Sep 13, 2024

Describe the solution you'd like

The chart already generates a bunch of well-known and recommended Kubernetes labels:

app.kubernetes.io/name: {{ include "k8s-service.name" . }}
app.kubernetes.io/instance: {{ .Release.Name }}
app.kubernetes.io/managed-by: {{ .Release.Service }}

It seems reasonable to allow users feed the chart with values for additional well-known labels like app.kubernetes.io/version

Describe alternatives you've considered

It is possible to inject the requested app.kubernetes.io/version label with additionalDeploymentLabels and additionalPodLabels, but allowing users to specify version as a dedicated Helm value seems reasonable in the spirit of all app.kubernetes.io labels or none.

Additional context

n/a

@mloskot mloskot added the enhancement New feature or request label Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant