Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace set-output usage with GITHUB_OUTPUT #42

Open
woodruffw opened this issue Jun 25, 2024 · 3 comments · May be fixed by #43
Open

Replace set-output usage with GITHUB_OUTPUT #42

woodruffw opened this issue Jun 25, 2024 · 3 comments · May be fixed by #43

Comments

@woodruffw
Copy link

First of all, thank you for this action! It's been very useful.

I noticed while using it that it's using set-output internally, which has been deprecated by GitHub:

The set-output command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

GitHub's encouraged alternative is to use the $GITHUB_OUTPUT file, e.g.:

echo "foo=bar" >> "${GITHUB_OUTPUT}"

I'm not super familiar with Go, but I suspect you're using the deprecated set-output command indirectly through this line:

gha.SetOutput("issues", strings.Join(createdIssuesString, ","))

...and that upgrading to 1.1.0 or newer will fix the underlying implementation, per sethvargo/go-githubactions#49

@woodruffw
Copy link
Author

(I'm happy to send a PR for the above, as well. Just let me know!)

@guilhem
Copy link
Owner

guilhem commented Jun 25, 2024

Hi @woodruffw
Thanks for your issue, if you want to make a PR I will be happy to review.

@woodruffw woodruffw linked a pull request Jun 25, 2024 that will close this issue
@woodruffw
Copy link
Author

Opened #43 for this, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants