Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ER: The template for updating projects does not contain all the projects #6863

Closed
6 of 7 tasks
ExperimentsInHonesty opened this issue May 20, 2024 · 10 comments
Closed
6 of 7 tasks
Assignees
Labels
Complexity: See issue making label See the Issue Making label to understand the issue writing difficulty level ER Emergent Request good first issue Good for newcomers Issue Making: Level 2 Make issue(s) from an ER or Epic P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe

Comments

@ExperimentsInHonesty
Copy link
Member

ExperimentsInHonesty commented May 20, 2024

Emergent Requirement - Problem

The template for updating projects does not contain all the projects and I need to submit an update for Tech Work Experience

Issue you discovered this emergent requirement in

n/a

Date discovered

2024-05-20

Did you have to do something temporarily

  • YES, make this issue to include the changes we will need for the twe card
  • NO

Who was involved

@ExperimentsInHonesty @joshfishman

What happens if this is not addressed

I can't submit an update for Tech Work Experience project

Resources

Recommended Action Items

  • Make a new issue
    • update existing template with new field under the Update GitHub Link section
      Do you have any additional (other than your primary) GitHub repositories that your volunteers make issues or PRs against?  
      YES/NO
      If yes, list the repo URLs here
      
    • have Bonnie test the template changes by using it to submit the following changes for TWE
      • add another repo to pull contributors from
  • Discuss with team
  • Let a Team Lead know

Potential solutions [draft]

@ExperimentsInHonesty ExperimentsInHonesty added Feature Missing This label means that the issue needs to be linked to a precise feature label. size: 0.25pt Can be done in 0.5 to 1.5 hours ER Emergent Request role missing Complexity: Missing labels May 20, 2024
@ExperimentsInHonesty ExperimentsInHonesty added the time sensitive Needs to be worked on by a particular timeframe label May 20, 2024
@github-actions github-actions bot removed the time sensitive Needs to be worked on by a particular timeframe label May 20, 2024
@ExperimentsInHonesty ExperimentsInHonesty added role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe Issue Making: Level 2 Make issue(s) from an ER or Epic needs issue: medium ready for merge team needs a senior review either to do some re writing or to approve it for ready for prioritization and removed Feature Missing This label means that the issue needs to be linked to a precise feature label. role missing Complexity: Missing labels May 20, 2024
@ExperimentsInHonesty ExperimentsInHonesty added Added to dev/pm agenda and removed Added to dev/pm agenda ready for merge team needs a senior review either to do some re writing or to approve it for ready for prioritization labels May 20, 2024
@Zanderfeldt Zanderfeldt self-assigned this May 28, 2024

This comment was marked as outdated.

@jphamtv

This comment was marked as outdated.

@ExperimentsInHonesty ExperimentsInHonesty added Complexity: See issue making label See the Issue Making label to understand the issue writing difficulty level and removed needs issue: medium labels Jun 9, 2024
@t-will-gillis t-will-gillis added good first issue Good for newcomers and removed size: missing labels Jun 30, 2024
@daras-cu daras-cu self-assigned this Aug 26, 2024
@HackforLABot
Copy link
Contributor

Hi @daras-cu, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

@daras-cu
Copy link
Member

Availability: Evenings after 5 pm
ETA: 8/30 EOD

@daras-cu
Copy link
Member

I have created issue #7363 for this ER but had a few questions come up while working on it:

  • I added the same labels to the issue that are on this issue, minus the ER-specific ones. Is this correct?
  • More broadly I just want to confirm I understood the ER correctly. The problem it mentions is that Tech Work Experience is not included in the Project Card issue template, but the action items/the issue I wrote do not address that directly.

@t-will-gillis
Copy link
Member

t-will-gillis commented Aug 29, 2024

Hi @daras-cu I checked out #7363 and have a couple of suggestions:

  • I was initially confused about placing the code snippet:

    Under the current lines

    attributes:
      label: GitHub Link  
    
  • It would be clearer, I believe, if you said something closer to what is in the description above, i.e. "Under the existing field that ends with the lines: "

  • Also, the code snippet for insertion has some indentation misalignment: in the first line, - type: dropdown needs to align with id

  • Part of me thinks we need to specify that the new section needs to match the formatting of the rest of the file (even though that should be a given). Your call.

  • For your second point, I think you are correct and that both the Project Name and the Project Card URL sections need the TWE even though it was not specified in the description.

    • You could add two more action items, one for inserting - Tech Work Experience alphabetically in the "Project Name" section and the other for inserting alphabetically - tech-work-experience.md in the "Project Card URL" section.
    • (Not your scope but it seems like the "Project Name" and "Project Card URL" sections could be combined. Also, I wonder if there are additional projects and project urls that are missing? Not your scope either.)
  • About the labels: This issue is more complex than a good first issue- I think it is at least a Complexity: Small, and at least size: 0.5pt (3 hours or less- do you agree?)

@daras-cu
Copy link
Member

Thanks so much @t-will-gillis, I made changes to the issue:

  • Added action items for TWE options in the Project Name and URL sections (I noticed the Project Name options at least are not fully alphabetical maybe due to project status, so I checked the order of projects on the website and specified to add it in the same place)
  • Added more specific description of where to add the code for the new GitHub field
  • Fixed the indentation in the code snippet
  • Added a note about matching the indentation pattern to the other fields
  • Changed size and complexity labels - this is actually why I wanted to double check on using the original labels, I agree it is more complex than a good first issue and 3 hrs or less seems reasonable

I also changed the title and overview slightly to reflect the TWE additions. Let me know if everything looks alright!

@t-will-gillis
Copy link
Member

Hey @daras-cu Thanks for making the changes- looks good!

I just thought of one more item- in the description of the issue created from an ER, I like to add a line similar to below in "Resources/Instructions":

- This issue initiated by ER #6863

@daras-cu
Copy link
Member

@t-will-gillis great, I added the line . Thanks for your help and suggestions!

@daras-cu daras-cu added the ready for merge team needs a senior review either to do some re writing or to approve it for ready for prioritization label Aug 30, 2024
@t-will-gillis
Copy link
Member

@daras-cu Great, I will close this issue as completed and add Ready for Prioritization on #7363 so that Bonnie can comment on it and let you know if anything else needs to be changed. Thanks for working on this!

Closing this as completed, see #7363

@t-will-gillis t-will-gillis removed the ready for merge team needs a senior review either to do some re writing or to approve it for ready for prioritization label Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: See issue making label See the Issue Making label to understand the issue writing difficulty level ER Emergent Request good first issue Good for newcomers Issue Making: Level 2 Make issue(s) from an ER or Epic P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe
Development

Successfully merging a pull request may close this issue.

6 participants