Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use push_metrics instead of milemarker #57

Open
aelkiss opened this issue Aug 19, 2024 · 2 comments
Open

Use push_metrics instead of milemarker #57

aelkiss opened this issue Aug 19, 2024 · 2 comments

Comments

@aelkiss
Copy link
Member

aelkiss commented Aug 19, 2024

https://github.com/hathitrust/push_metrics

This way we should get alerts when the job fails for "free".

If we want to measure any other metrics we could do that too but I think we shuold start with getting basic job completion info.

@aelkiss
Copy link
Member Author

aelkiss commented Aug 19, 2024

This is already being used, but we should investigate why we aren't getting alerts when hathifiles aren't generated.

@aelkiss aelkiss closed this as completed Aug 19, 2024
@aelkiss aelkiss reopened this Aug 19, 2024
@aelkiss
Copy link
Member Author

aelkiss commented Aug 19, 2024

Looks like it may be reporting success even though it somehow failed? Not sure... Possible we're calling log_final_line (and thus indicating job success) even if there's an exception that prevents completion?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant