Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HxInputBase] Application-wide default for LabelType #890

Closed
hakenr opened this issue Sep 29, 2024 · 0 comments · Fixed by #873
Closed

[HxInputBase] Application-wide default for LabelType #890

hakenr opened this issue Sep 29, 2024 · 0 comments · Fixed by #873
Assignees
Labels
enhancement New feature or request

Comments

@hakenr
Copy link
Member

hakenr commented Sep 29, 2024

Extracted from #872 for @mmonteagudo, where there were two features combined into single issue.

For now, I've decided not to accept the idea of adding the ValidationFor, ValidationForFieldName, and ValidationEditContext parameters to HxInputBase (i.e., to every input component).

However, I do like the idea of having a central place to set the default LabelType for all input components, and I'll try to finish that based on PR #873 (I'll revert the validation-related changes and fine-tune the LabelType idea).

@hakenr hakenr added the enhancement New feature or request label Sep 29, 2024
@hakenr hakenr self-assigned this Sep 29, 2024
@hakenr hakenr added this to the Priority 2 - Normal milestone Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant