Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

telnetlib removal with Python 3.13 (PEP 594) #67

Closed
herrnst opened this issue Oct 22, 2023 · 1 comment
Closed

telnetlib removal with Python 3.13 (PEP 594) #67

herrnst opened this issue Oct 22, 2023 · 1 comment

Comments

@herrnst
Copy link
Owner

herrnst commented Oct 22, 2023

script.xbmc.lcdproc right now relies on and makes use of the telnetlib module. telnetlib is marked as deprecated since Python 3.11 and will ultimately be removed in Python version 3.13 (see PEP 594) for details.

The communication to the LCDproc service needs to be reworked to use something else that is not telnetlib due to that, else script.xbmc.lcdproc will stop working as soon as Python 3.13 is involved.

All usage is within resources/lib/lcdproc.py, and the best option right now seems to be to use a plain socket for this, as all command submission already uses the raw socket provided by the telnetlib object.

@m-wichmann
Copy link

I reworked the socket code in #70. I tested it locally on Fedora 41 and it seems to work. More tests might be needed for more complex setups.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants