Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy csi-driver #50

Closed
simonhammes opened this issue Sep 29, 2024 · 4 comments · Fixed by #51 or #52
Closed

Deploy csi-driver #50

simonhammes opened this issue Sep 29, 2024 · 4 comments · Fixed by #51 or #52
Labels
enhancement New feature or request

Comments

@simonhammes
Copy link
Contributor

TL;DR

It would save me a few keystrokes each time if there was an option to deploy https://github.com/hetznercloud/csi-driver :)

Expected behavior

https://github.com/hetznercloud/csi-driver would be deployed if a variable (e.g. deploy_csi_driver) is set to true.

I can create a PR if you'd be willing to accept it.

@simonhammes simonhammes added the enhancement New feature or request label Sep 29, 2024
@apricote
Copy link
Member

Sounds good :) So far we only added what we needed in hcloud-cloud-controller-manager and csi-driver. Installing the csi-driver might be interesting for when we use this in cluster-autoscaler.

Out of curiosity, where are you using kubernetes-dev-env that you need csi-driver?

@simonhammes
Copy link
Contributor Author

simonhammes commented Sep 30, 2024

Sounds good :) So far we only added what we needed in hcloud-cloud-controller-manager and csi-driver. Installing the csi-driver might be interesting for when we use this in cluster-autoscaler.

Okay, I'll send a PR :)

Out of curiosity, where are you using kubernetes-dev-env that you need csi-driver?

I'm using it for developing my own stuff in order to lean more about K8S and want to have a development environment that's comparable to a managed K8S service at some large cloud provider (without paying a stupid amount of money). I could have used https://github.com/vitobotta/hetzner-k3s, but this project already has a registry configured (don't know about hetzner-k3s) and it just works!

Or would you recommend a different solution that might better fit my needs?

But maybe I did not fully understand the intent of your question 😅

@apricote
Copy link
Member

apricote commented Oct 1, 2024

When we wrote this we had the very specific use-case of developing our integrations in mind. To keep it simple the project is really only intended for very short lived clusters used in development & testing. When we created this project there was some discussion around people using it to deploy their long-lived clusters, which is why we added the disclaimers and warning to the README.

I had not considered that it can be used for (regular application) development by other people, but nice to hear that its working for you :)

@simonhammes
Copy link
Contributor Author

Yeah, that makes sense. I'm using it for short-lived clusters.

Unfortunately some (stateful) applications require volumes, and solutions like emptyDir or hostPath have other disadvantages.

lukasmetzner pushed a commit that referenced this issue Oct 23, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.6.0](v0.5.2...v0.6.0)
(2024-10-23)


### Features

* optional csi-driver deployment
([#51](#51))
([331c11b](331c11b)),
closes
[#50](#50)


### Bug Fixes

* Move infrastructure to Helsinki
([#57](#57))
([08dfcfd](08dfcfd))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants