Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WearOS: Add app activities to ShortcutsTile #4556

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

WearOS: Add app activities to ShortcutsTile #4556

wants to merge 2 commits into from

Conversation

RoboMagus
Copy link
Contributor

Summary

This adds the option to add buttons to launch either the Companion app, or the Assist dialog to the ShortcutsTile.
See #4550

Screenshots

Shortcut tile with newly added buttons;
ShortcutTile

Config for this example;
ShortcutTileConfig

New button options are added at the bottom of the entity selection list under the shortcuts section;
ShortcutActivityOptions

Link to pull request in Documentation repository

Documentation: home-assistant/companion.home-assistant#

Any other notes

  1. This implementation has been tested only on an AndroidStudio emulator.
  2. It seems that the HA Icon included in the CommunityMaterial.Icon library has not yet been updated.
  3. I'm not fluent in Kotlin / Android app development, so if there's any improvements to be made I'm happy to learn :)

@dshokouhi dshokouhi linked an issue Aug 6, 2024 that may be closed by this pull request
WearOS: Option for adding an 'Assist' shortcut to Shortcut-Tiles #4550
Open
@dshokouhi
Copy link
Member

  • It seems that the HA Icon included in the CommunityMaterial.Icon library has not yet been updated.

Yea I am not sure it will be acceptable to include the old branding there 🤔

@jpelgrom
Copy link
Member

jpelgrom commented Aug 8, 2024

  • It seems that the HA Icon included in the CommunityMaterial.Icon library has not yet been updated.

Yea I am not sure it will be acceptable to include the old branding there 🤔

MDI is dropping brand icons in the next major release so probably not open to updating, so I think the way forward is to load the icon from the app's resources in this specific case.

@RoboMagus
Copy link
Contributor Author

Yea I am not sure it will be acceptable to include the old branding there 🤔

Well, any entities inside HA that have its icon set to mdi:home-assistant will still show the old icon too.
So this would best be addressed at the icon library side.

@dshokouhi
Copy link
Member

Yea I am not sure it will be acceptable to include the old branding there 🤔

Well, any entities inside HA that have its icon set to mdi:home-assistant will still show the old icon too. So this would best be addressed at the icon library side.

Yea for any entities a user has defined is fine, but since we are creating this entry it should use the appropriate icon

@RoboMagus
Copy link
Contributor Author

RoboMagus commented Aug 18, 2024 •
edited
Loading

If you agree with this approach I'd prefer looking into creating a separate PR which would patch any use of mdi:home-assistant to be in line with what would be shown on the web version of the HA instance for consistency across platforms. That way any use of the HA icon would be using the new icon instead of the old one.

EDIT:
See PR #4587

@RoboMagus RoboMagus mentioned this pull request Aug 18, 2024
Open
@jpelgrom
Copy link
Member

Changing this to draft while waiting for the other PR

@jpelgrom jpelgrom marked this pull request as draft September 11, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dshokouhi dshokouhi dshokouhi left review comments

Assignees
No one assigned
Labels
cla-signed Wear OS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WearOS: Option for adding an 'Assist' shortcut to Shortcut-Tiles
3 participants
@RoboMagus @dshokouhi @jpelgrom