Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fitbit integration and multiple accounts: devices and entities have no account identifier in names #123893

Open
RealGandy opened this issue Aug 14, 2024 · 3 comments · May be fixed by #130828
Open

Fitbit integration and multiple accounts: devices and entities have no account identifier in names #123893

RealGandy opened this issue Aug 14, 2024 · 3 comments · May be fixed by #130828
Assignees
@allenporter
Labels
integration: fitbit

Comments

@RealGandy
Copy link

The problem

When adding multiple fitbit accounts to retrieve data for multiple peple, the devices and entities that get created do not contain the 'Application Credentials' name.

If I create Fitbit Application Credentials named User1 and User2, the devices and entities do not include these in the names.

The first item configured will have entities created such as sensor.steps and the second one will have sensor.steps_2 making it difficult to know which is which. The integration should create objects with a name that includes an identifier to understand which crednetials are being used, either by using the credentials name or something retrieved from the api being called.

What version of Home Assistant Core has the issue?

core-2024.8.1

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant Container

Integration causing the issue

Fitbit

Link to integration documentation on our website

https://www.home-assistant.io/integrations/fitbit/

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response
@home-assistant
Copy link

Hey there @allenporter, mind taking a look at this issue as it has been labeled with an integration (fitbit) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of fitbit can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Renames the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign fitbit Removes the current integration label and assignees on the issue, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

(message by CodeOwnersMention)

fitbit documentation
fitbit source
(message by IssueLinks)

@RealGandy RealGandy changed the title Fitbit integration and multiple accounts need devices and entities have no account identifier in names Fitbit integration and multiple accounts devices and entities have no account identifier in names Aug 14, 2024
@RealGandy RealGandy changed the title Fitbit integration and multiple accounts devices and entities have no account identifier in names Fitbit integration and multiple accounts: devices and entities have no account identifier in names Aug 14, 2024
@issue-triage-workflows
Copy link

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates.
Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍
This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

@allenporter
Copy link
Contributor

Thanks for the report. Perhaps we need to use the config entry title name or make a device name based on the config entry title.

I think a couple sensors like battery level have this naming scheme but the others do not.

@allenporter allenporter linked a pull request Nov 17, 2024 that will close this issue
Open
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@allenporter allenporter

Labels
integration: fitbit
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Modernize Fitbit entity names allenporter/home-assistant-core
2 participants
@RealGandy @allenporter