Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Risco integration is asking for code even when configured not to #130862

Open
ekutner opened this issue Nov 18, 2024 · 2 comments · May be fixed by #130908
Open

Risco integration is asking for code even when configured not to #130862

ekutner opened this issue Nov 18, 2024 · 2 comments · May be fixed by #130908
Labels
integration: risco

Comments

@ekutner
Copy link

ekutner commented Nov 18, 2024

The problem

The Risco integration allows setting "No code required" for arming and disarming the alarm. However the code is still requested even when those configuration options are selected. The reason for that is this line:
_attr_code_format = CodeFormat.NUMBER
The code format attribute should be None when a code is not required.

I can submit a PR to fix this if that is preferred.

What version of Home Assistant Core has the issue?

2024.11.2

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant OS

Integration causing the issue

Risco

Link to integration documentation on our website

https://www.home-assistant.io/integrations/risco

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response
@home-assistant
Copy link

Hey there @OnFreund, mind taking a look at this issue as it has been labeled with an integration (risco) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of risco can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Renames the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign risco Removes the current integration label and assignees on the issue, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

(message by CodeOwnersMention)

risco documentation
risco source
(message by IssueLinks)

@OnFreund
Copy link
Contributor

Yes, please submit a PR, thanks!

@ekutner ekutner linked a pull request Nov 18, 2024 that will close this issue
Open
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
integration: risco
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Risco code_format when a code is not required ekutner/Home-Assistant-Core
2 participants
@OnFreund @ekutner