Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update elmax_api to v0.0.6.1 #130917

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

Update elmax_api to v0.0.6.1 #130917

wants to merge 3 commits into from
+3 −3

Conversation

ElmaxSrl
Copy link

@ElmaxSrl ElmaxSrl commented Nov 18, 2024 •
edited
Loading

Proposed change

Update elmax_api to v0.0.6.1
albertogeniola/elmax-api@v0.0.5...v0.0.6.1

This PR fixes #131216

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • [] Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This (very small) PR addresses a change in a dependency lib (elmax_api) changed due to an incompatibility seen with a newer version of websocket lib

albertogeniola/elmax-api@v0.0.5...v0.0.6.1

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @albertogeniola, mind taking a look at this pull request as it has been labeled with an integration (elmax) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of elmax can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign elmax Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

epenet
epenet requested changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@epenet epenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for bumping the dependency! However, could you please update the PR description to contain at least one (or multiple) of the following:

  • A link to the release notes of this package version, and all versions in between.
  • A link to the changelog of this package.
  • A link to a Git(Hub) diff/compare view from the current version to the bumped version.

This allows us to review upstream changes, which is needed to decide this change is working as intended and/or if we can include it in, for example, a patch release of Home Assistant.

Thanks already! 👍

PS. Please also ensure that you run python -m script.gen_requirements_all to update the requirements files accordingly
PPS. You have ticked "breaking changes", so please indicate in the PR description what the breaking changes are for the integration users

@home-assistant home-assistant bot marked this pull request as draft November 19, 2024 06:46
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@albertogeniola
Copy link
Contributor

Legit

@ElmaxSrl
Copy link
Author

Thanks for bumping the dependency! However, could you please update the PR description to contain at least one (or multiple) of the following:

  • A link to the release notes of this package version, and all versions in between.
  • A link to the changelog of this package.
  • A link to a Git(Hub) diff/compare view from the current version to the bumped version.

This allows us to review upstream changes, which is needed to decide this change is working as intended and/or if we can include it in, for example, a patch release of Home Assistant.

Thanks already! 👍

PS. Please also ensure that you run python -m script.gen_requirements_all to update the requirements files accordingly PPS. You have ticked "breaking changes", so please indicate in the PR description what the breaking changes are for the integration users

Hi @epenet

as requested i've added more informations on the opening post.

@epenet
Copy link
Contributor

epenet commented Nov 19, 2024

PS. Please also ensure that you run python -m script.gen_requirements_all to update the requirements files accordingly
PPS. You have ticked "breaking changes", so please indicate in the PR description what the breaking changes are for the integration users

Hi @epenet

as requested i've added more informations on the opening post.

Please review the remaining two items above

albertogeniola
albertogeniola suggested changes Nov 19, 2024
View reviewed changes
homeassistant/components/elmax/manifest.json Outdated
@@ -6,7 +6,7 @@
"documentation": "https://www.home-assistant.io/integrations/elmax",
"iot_class": "cloud_polling",
"loggers": ["elmax_api"],
"requirements": ["elmax-api==0.0.5"],
"requirements": ["elmax-api==0.0.6"],
Copy link
Contributor

@albertogeniola albertogeniola Nov 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move to 0.0.6.1 (link) which relies to websockets 13.0+: that one should be compatible with most of the other libraries here.

@ElmaxSrl ElmaxSrl changed the title Update elmax_api to v0.0.6 Update elmax_api to v0.0.6.1 Nov 19, 2024
ElmaxSrl
ElmaxSrl commented Nov 19, 2024
View reviewed changes
Copy link
Author

@ElmaxSrl ElmaxSrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move to 0.0.6.1 (link) which relies to websockets 13.0+: that one should be compatible with most of the other libraries here.

@ElmaxSrl ElmaxSrl marked this pull request as ready for review November 20, 2024 10:03
epenet
epenet requested changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@epenet epenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have already requested these twice:

  • Please also ensure that you run python -m script.gen_requirements_all to update the requirements files accordingly, as the PR cannot be merged without it
  • You have ticked "breaking changes", so please indicate in the PR description what the breaking changes are for the integration users

@home-assistant home-assistant bot marked this pull request as draft November 20, 2024 10:06
@ElmaxSrl
Copy link
Author

Hi @epenet, all steps requested are done now

@ElmaxSrl ElmaxSrl marked this pull request as ready for review November 21, 2024 21:44
albertogeniola
albertogeniola approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@albertogeniola albertogeniola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Legit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albertogeniola albertogeniola albertogeniola approved these changes

@epenet epenet Awaiting requested review from epenet

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
bugfix cla-signed dependency integration: elmax Quality Scale: No score small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Elmax API Websocket connection error
3 participants
@ElmaxSrl @albertogeniola @epenet