Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logbook: Use actual states for update entities instead of "turned on" or "turned off" #22862

Open
NoRi2909 opened this issue Nov 18, 2024 · 1 comment

Comments

@NoRi2909
Copy link
Contributor

NoRi2909 commented Nov 18, 2024

Describe the issue you are experiencing

For update entities the logbook entries don't reflect the actual states which creates the hard to understand relation that

off  =  up-to-date

which is technically correct but in the More info dialog with History and Logbook side-by-side it looks very confusing:

Screenshot 2024-11-18 16 30 48

While the state in History is correctly mapped to as "Up-to-date" or "Update available" from

https://github.com/home-assistant/core/blob/efa86293aa47f8f7b5395cd0b48f72ea8002b674/homeassistant/components/update/strings.json#L13-L15

the Logbook entries contain only the generic states "turned off" and "turned on".

While this is already quite inconsistent in English it gets really confusing in translations like in German where "turned off" is more like "was turned off" ("wurde ausgeschaltet").

Describe the behavior you expected

Would be cool to see these use the customs states for the entities. The string to hold those is already present here:

"changed_to_state": "changed to {state}",

so we'd have

 changed to Up-to-date
 changed to Update available

What version of Home Assistant Core has the issue?

core-2024.11.2

@NoRi2909
Copy link
Contributor Author

Here the opposite where it should say "Changed to Update available":

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant