RangeError on big folders

[dwidge]

When a very big folder is present in srcDir, sometimes we get RangeError: Maximum call stack size exceeded, even if we exclude the folder. Also takes time to deep scan the folder.

syncdir srcDir targetDir -e node_modules

Related:
JS-DevTools/readdir-enhanced#11

[hoperyy]

Good job!

[tehvgg]

I see this changed to no-deep but it doesn't behave as expected.

I add -e node_modules and the expectation should automatically be that excluded folders are not looked at in any way... I get the call stack error with -e but I don't get one without it (sync-dir starts copying everything in node_modules).

I used -nd along with the -e but now it's only syncing my top level files.

@dwidge original update seemed to target just the impact of -e, but the current behavior is that -nd impacts the entire scope instead.

[hoperyy]

@tehvgg I'm not quite sure if this is a reproducible bug. I've tested the options below: -nd; -e

srcDir is like this:

sync-dir srcDir targetDir -e dir1

sync-dir srcDir targetDir -e dir1 -nd

Can you show your directory structure or other to represent this bug?

[tehvgg]

@hoperyy sorry for the delayed reply, I didn't know I had notifications off

My folder structure is a bit different:

project-a/
  src/
  node_modules/
  package.json

project-b/
  src/
  node_modules/
  package.json

I make changes inside project-b/src and want those changes to be copied over to project-a/node_modules.

project-a and project-b are sibling folders, and my script runs from inside project-a

sync-dir ../project-b/packages/foo ./node_modules/@internal/foo -e node_modules -w -nd

Normally I would use yarn link but this is a React Native project and there's symlink issues with RN.

[dwidge]

readdirEnhanced can skip deep scan if passed filter function

deep: nodeep ? filter : true