Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Simplify SQL for selecting an entire table" #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Revert "Simplify SQL for selecting an entire table" #4

wants to merge 1 commit into from

Conversation

ap
Copy link
Contributor

@ap ap commented Aug 29, 2023

This fixes #3.

@ap ap mentioned this pull request Aug 29, 2023
Open
@autarch
Copy link
Member

autarch commented Sep 2, 2023

Argh, it looks like (unrelated to this PR) the t/SQL/Select-from-clause.t test now segfault on all Perls from 5.26 onwards. Why? I have no clue. It makes a little harder to be confident about any changes we make to this code :(

@autarch
Copy link
Member

autarch commented Sep 2, 2023

This happens with both main and this PR, FWIW.

@ap
Copy link
Contributor Author

ap commented Sep 2, 2023

Well if main and the PR both pass on 5.24 then I’d assume the segfault has nothing to do with the PR and it’s safe to merge. I’d not take this lackadaisical a tack normally but I’m afraid I’m not going to bother looking into anything past #3 (which I take responsibility for).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Behavior change in 0.41 breaks functionality of Fey::Object::Iterator::FromSelect
2 participants
@ap @autarch