Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unit1/01 clarity needed #70

Open
ppbrown opened this issue Nov 30, 2023 · 0 comments
Open

unit1/01 clarity needed #70

ppbrown opened this issue Nov 30, 2023 · 0 comments

Comments

@ppbrown
Copy link

ppbrown commented Nov 30, 2023

I'm trying to wade my way through
https://github.com/huggingface/diffusion-models-class/blob/main/unit1/01_introduction_to_diffusers.ipynb

Fairly informative overall, but a few things mire me down, in Step 4:

  1. It is confusing that the IMAGE shows 5 green blocks, and the description says "down_block_types correspond to the [green blocks]"... but in the code, down_block_types has 4 entries. Super confusing. Image needs to be remade to match up with code better.

  2. It is completely unclear what "block_out_channels" is for.

  3. "Middle block" is shown very noticably in the image, but there is zero explaination for them that I can see? They arent even refernced visibly in the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant