Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible ambiguous GraphQL request logging #63

Open
ubiuser opened this issue Jun 6, 2022 · 0 comments
Open

Possible ambiguous GraphQL request logging #63

ubiuser opened this issue Jun 6, 2022 · 0 comments
Assignees
Labels

Comments

@ubiuser
Copy link

ubiuser commented Jun 6, 2022

Based on the gqlgen lifecycle example presented in https://github.com/99designs/gqlgen/blob/ddd825ef62f1fa7cbc0824c1696f72a3c67d78e0/graphql/handler.go#L45, multiple responses can be sent for the same subscription operation, which means

gh.AroundResponses(GqlLoggingMiddleware)
should probably use AroundOperations instead of AroundResponses to avoid multiple log lines for the same request.

@ubiuser ubiuser added the bug label Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants