Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visualization: Table: re-port from UI codebase without architectural changes #824

Open
TCL735 opened this issue Oct 24, 2022 · 0 comments
Open

Comments

@TCL735
Copy link
Contributor

TCL735 commented Oct 24, 2022

There are a couple of nagging issues with Table that should be fixed. As one of the fundamental visualizations, there shouldn't be any bugs associated with Table. And even though there may be pending design and product changes for Table, the existing stuff should work.

Proposal

Instead of porting the Table visualization code from the UI with changes (by attempting to use functional components rather than class components), the port should just be exactly as-is with only minimal and necessary changes. Also, any minor bugs should be fixed. But none of this should be done by changing the underlying code architect such as moving from class components to functional components. The differences between these two implementations may be the reason for the nagging issues.

Specifically, by doing the above, we are consolidating and hoping to address the following:
#788
influxdata/ui#6147

@TCL735 TCL735 changed the title Table: re-port from UI codebase without removing class components Visualization: Table: re-port from UI codebase without removing class components Oct 24, 2022
@TCL735 TCL735 self-assigned this Oct 24, 2022
@TCL735 TCL735 changed the title Visualization: Table: re-port from UI codebase without removing class components Visualization: Table: re-port from UI codebase without architectural changes Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant