Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCL][Fusion] Remove kernel fusion stubs #15184

Open
sommerlukas opened this issue Aug 23, 2024 · 0 comments
Open

[SYCL][Fusion] Remove kernel fusion stubs #15184

sommerlukas opened this issue Aug 23, 2024 · 0 comments
Assignees
@sommerlukas
Labels
abi-break change that's breaking abi and waiting for the next window to be able to merge confirmed

Comments

@sommerlukas
Copy link
Contributor

Is your feature request related to a problem? Please describe

The kernel fusion integration into the scheduler was removed to make the scheduler leaner.

Some functions and classes could not be removed entirely, as doing so would constitute an ABI-breaking change. For the time being, they have been replaced with dummy implementations.

In the next ABI-breaking window, those stubs should then be removed entirely.

This includes:

  • Multiple entries in DataLessPropKind
  • queue::supports_fusion()
  • fusion_wrapper[.cpp/.hpp]
  • The supports_fusion device aspect

Describe the solution you would like

No response

Describe alternatives you have considered

No response

Additional context

No response
@sommerlukas sommerlukas added the abi-break change that's breaking abi and waiting for the next window to be able to merge label Aug 23, 2024
@sommerlukas sommerlukas self-assigned this Aug 23, 2024
@sommerlukas sommerlukas mentioned this issue Aug 23, 2024
Merged
martygrant pushed a commit that referenced this issue Sep 4, 2024
@sommerlukas
[SYCL] Remove fusion scheduler integration (#15185)
4aee47a 
Remove the integration of kernel fusion from the SYCL runtime scheduler.
This makes the implementation of the scheduler less complex and leaner.

As a consequence, the experimental kernel fusion feature is no longer
supported, the extension proposal status has been updated.

Some stubs of the kernel fusion must remain for now to avoid ABI-break,
removing those stubs in the next ABI-breaking window is tracked through
#15184.

---------

Signed-off-by: Lukas Sommer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sommerlukas sommerlukas

Labels
abi-break change that's breaking abi and waiting for the next window to be able to merge confirmed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sommerlukas @KornevNikita