Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client Side Editing: TestCase classes that extend %UnitTest.TestCase indirectly are not "runnable" #27

Open
tanifgit opened this issue Feb 7, 2024 · 1 comment

Comments

@tanifgit
Copy link

tanifgit commented Feb 7, 2024

If you have a test case class that extends %UnitTest.TestCase but in an indirect way (i.e. a class that is not named %UnitTest.TestCase, but rather a class that in turn extends it; or somewhere up the hierarchy, which could be common practice for organizations managing their test cases), the classes will not show with their methods/tests, and will not be runnable.

I believe that while the server-side editing related code (ServerTests.ts):
{ query: 'CALL %Dictionary.ClassDefinition_SubclassOf('%UnitTest.TestCase', '${(namespace === "%SYS" ? "" : "@")}') '},
Runs a query that will indeed return all sub-classes, the client-side editing related code (LocalTests.ts) performs this kind of check:

if (lineText.startsWith('Class ')) {
                                if (!lineText.includes('%UnitTest.TestCase')) {
                                    break;
                                }

Which naturally will only find classes that explicitly have the %UnitTest.TestCase in their Extends definition.

@isc-bsaviano
Copy link

@tanifgit Since version 2.12.0 the vscode-objectscript extension has had %UnitTest running capabilities built in. It should allow the running of local test classes that aren't direct subclasses of %UnitTest.TestCase. You can read the docs for that new feature here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants