Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow override of scrollViewDidScroll in CardsViewController #245

Open
jmjordan opened this issue May 1, 2020 · 3 comments
Open

Allow override of scrollViewDidScroll in CardsViewController #245

jmjordan opened this issue May 1, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@jmjordan
Copy link
Contributor

jmjordan commented May 1, 2020

Is your feature request related to a problem? Please describe.
I would like to be able to override scrollViewDidScroll in a CardsViewController for custom UI

Describe the solution you'd like
Change scrollViewDidScroll in CardsViewController to open

Describe alternatives you've considered
A custom delegate method could be created but I don't think that's necessary

Additional context
None
@jmjordan jmjordan added the enhancement New feature or request label May 1, 2020
@jmjordan
Copy link
Contributor Author

jmjordan commented May 1, 2020

I'm happy to do the work if it is approved.

@badrinathvm
Copy link
Contributor

badrinathvm commented May 5, 2020 •
edited
Loading

@jmjordan Please send us PR we will review and take it further. Thank you.

@jmjordan
Copy link
Contributor Author

jmjordan commented May 7, 2020 •
edited
Loading

PR submitted: #247

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jmjordan @badrinathvm