Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

init is too restrictive for svd or knn methods #93

Open
rofinn opened this issue Nov 11, 2020 · 0 comments
Open

init is too restrictive for svd or knn methods #93

rofinn opened this issue Nov 11, 2020 · 0 comments

Comments

@rofinn
Copy link
Member

rofinn commented Nov 11, 2020

I think if all Imputors or Chains were just callable then I think the init field for svd could just be a callable with 3 assumptions that can be explicitly specified.

  1. the init callable should fill in all values
  2. it does not mutate the original data
  3. follow the method signature of init(data; dims=dims)

If any of those fail then it can just error appropriately at runtime either with a method error or explicit assertion.

Related to #89

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant