fix(android): respect all allowed origins on modern WebViewCompat JS injection #7571
+6
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
Is there a chance this to be merged? |
|
Since I added this fix, I had the chance to test it on a device that was affected by the bug and this patch works flawlessly. @michaelkhabarov No idea at this point. I got silenced at #7570, too, but it's an entirely different issue that was confused with the existing one. It makes me feel discouraged for contributing any further. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7454
I applied the fix from @rfe-css at #7454, but I figured my device would skip this, so please someone can verify this before merge.