Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

write content for ES2015 tutorial #8

Open
bcoe opened this issue Aug 3, 2016 · 17 comments
Open

write content for ES2015 tutorial #8

bcoe opened this issue Aug 3, 2016 · 17 comments

Comments

@bcoe
Copy link
Member

bcoe commented Aug 3, 2016

I would love help pulling together a tutorial, regarding adding test-coverage to ES6 projects using nyc, babel-plugin-istanbul, etc.

I've added this section waiting to be filled in:

http://istanbul.js.org/2016/08/02/es6.html

@insin, @graingert, @kentcdodds, don't suppose you could help pull something together.

@graingert
Copy link
Contributor

es6 is not the correct term. You should use es2016, or maybe TC39

@graingert
Copy link
Contributor

please please please help kill the term 'es6'

@graingert
Copy link
Contributor

also the current documentation talks about nyc. Isn't nyc going to become npm install istanbul

@bcoe
Copy link
Member Author

bcoe commented Aug 3, 2016

@graingert all this, and much more, could be addressed in the content proposed in this issue/corresponding pull request 👯

@graingert nyc is mostly likely going to remain a stand-alone bin in the near future.

@bcoe bcoe changed the title write content for ES6 tutorial write content for ES2016 tutorial Aug 3, 2016
@graingert
Copy link
Contributor

@bcoe you're really twisting my arm here....!

@graingert
Copy link
Contributor

@graingert
Copy link
Contributor

@bcoe also do this js-org/js.org#779

@kentcdodds
Copy link
Member

es6 is not the correct term. You should use es2016, or maybe TC39

I think you mean es2015 :) es6 !== es2016. Also, TC39 doesn't make sense...

please please please help kill the term 'es6'

You can pry that term out of my cold dead fingers ;-) But I'm all good with the new naming convention after that :) (es2016, es2017, etc).

@bcoe
Copy link
Member Author

bcoe commented Aug 3, 2016

@graingert see last comment on:

#10

Goal is to help folks find the documentation they're looking for, more so than using the perfect term. I know you're joking, but let's try to work together discussing tutorial comment and not get hung up on this.

@bcoe bcoe changed the title write content for ES2016 tutorial write content for ES2015 tutorial Sep 8, 2016
@bcoe
Copy link
Member Author

bcoe commented Sep 8, 2016

@kentcdodds @novemberborn @hzoo @gotwarlost I gave a presentation on ES2015 test coverage to npm engineering today, and pulled together a first pass at this tutorial:

http://istanbul.js.org/docs/tutorials/es2015/

Would love your feedback, and will happily pull in any edits.

@bcoe
Copy link
Member Author

bcoe commented Sep 8, 2016

CC: @MoOx (see above)

@graingert
Copy link
Contributor

graingert commented Sep 8, 2016

I'd probably mention https://github.com/michaelcontento/babel-preset-modern-node along with node.green as node isn't quite 100% on ES2015.

(Although modern-node follows the latest released ES spec so it's on ES2016 now)

@hzoo
Copy link

hzoo commented Sep 8, 2016

If you aren't using babel-core directly (looks like it's babel-core/register) you can just use the babel-register package.

@hzoo
Copy link

hzoo commented Sep 8, 2016

Would be nice to include node in https://github.com/babel/babel-preset-env, we should ask all the node-x, w.e presets to help out.

This is new but you can use the latest preset instead of es2015 (https://github.com/babel/babel/releases/tag/v6.14.0). You can pass in es2015, and those options as well.

@bcoe
Copy link
Member Author

bcoe commented Sep 8, 2016

@hzoo can we drop the babel-core dependency and just use babel-register? for some reason I thought babel-core was required for the preset. That simplifies things even more.

Would be nice to include node in https://github.com/babel/babel-preset-env, we should ask all the node-x, w.e presets to help out

That's a great idea. CC: @addaleax (thoughts on this topic?)

@bcoe
Copy link
Member Author

bcoe commented Sep 8, 2016

@graingert great suggestion.

@hzoo
Copy link

hzoo commented Sep 8, 2016

Right babel-core is already a dependency in babel-cli, it's not necessary (only when using babel-loader since it's a peerDep in that case).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants